Handle redirects when fetching AWS IAM metadata#8452
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 2, 2019
Merged
Handle redirects when fetching AWS IAM metadata#8452mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Fixes: envoyproxy#8325 Signed-off-by: Scott LaVigne <lavignes@amazon.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Fixes: envoyproxy#8325 Signed-off-by: Scott LaVigne <lavignes@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8325
Description: By default cURL does not follow redirects. When fetching AWS IAM credentials, some endpoints may opt to redirect instead of handling paths with trailing slashes. In general, we should be following any redirect from these endpoints for maximum compatibility.
Risk Level: LOW
Signed-off-by: Scott LaVigne lavignes@amazon.com