Conversation
Also, add it back in when calling the POOL_*_PREFIX macros. Signed-off-by: Kevin Burek <kburek@lyft.com>
|
@jmarantz when you review can you also check to see if any of the other conversions have a similar issue? Also, is there anything that we could be doing to better test this holistically? Thank you. |
|
Can you run the format-fixer? I'm actually trying to understand what you are fixing. I merged to master in a client and then ran a test with some assertions and I didn't see a scenario where a stat was missing its dot in unit tests. The test I ran was this: I'm still running the full testsuite and I haven't seen any problems yet. First I ran and to my surprise it passed. So what am I missing here? |
|
OK I see some failures now with at assert; though not in Mongo. Will follow up. |
|
I see -- the bug wasn't that we were lacking the trailing dot on the prefix used for constructing stats with macros. The bug was that we had an extra trailing dot for capturing the prefix as a StatName. I have an ASSERT that I think helps for that, in the 2 impls of SymboTable::encode: that fires for this case; we'll see how many more. |
|
I have a more comprehensive version of this in #8445 |
|
Thanks! 😃 |
Removes the trailing '.' from MongoStats stat_prefix format.
Inserting the separator happens when calling the POOL_*_PREFIX macros instead.
Risk Level: Low
Testing: Brought unit test init in line with factory method createFilterFactoryFromProtoTyped
Docs Changes: -
Release Notes: -
Fixes #8442