refactor: move TransportSocketOptions into LoadBalancerContext#8424
Merged
lizan merged 4 commits intoenvoyproxy:masterfrom Oct 1, 2019
Merged
refactor: move TransportSocketOptions into LoadBalancerContext#8424lizan merged 4 commits intoenvoyproxy:masterfrom
lizan merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
snowp
suggested changes
Sep 30, 2019
| virtual Network::Socket::OptionsSharedPtr upstreamSocketOptions() const PURE; | ||
|
|
||
| /** | ||
| * Returns the transprot socket options which should be applied on upstream connections |
Member
There was a problem hiding this comment.
Weird that the spell checker didn't find this.
| if (transport_socket_options != nullptr) { | ||
| transport_socket_options->hashKey(hash_key); | ||
| bool have_transport_socket_options = false; | ||
| if (context && context->upstreamTransportSocketOptions() != nullptr) { |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
zuercher
reviewed
Oct 1, 2019
Member
zuercher
left a comment
There was a problem hiding this comment.
One nit, but otherwise LGTM.
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…proxy#8424) Description: Needed for envoyproxy#2690 to use TransportSocketOptions in HTTP cluster. Risk Level: Low (refactor only) Testing: existing Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Needed for #2690 to use TransportSocketOptions in HTTP cluster.
Risk Level: Low (refactor only)
Testing: existing
Docs Changes: N/A
Release Notes: N/A