Enforce hashtagging for Redis clusters#8418
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Sep 30, 2019
Merged
Conversation
Signed-off-by: Henry Yang <hyang@lyft.com>
mattklein123
requested changes
Sep 30, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Generally LGTM but hoping that we can make the code a bit simpler to understand. Thank you!
/wait
| public Upstream::LoadBalancerContextBase { | ||
| public: | ||
| /** | ||
| * The load balancer context for Redis requests. Note that use_crc16 implies using Redis cluster |
Member
There was a problem hiding this comment.
The fact that use_crc16 implied redis cluster is kind of confusing. Can you potentially rename this variable in some way to make this more clear? It seems like this type of logic is better handled at the caller?
Contributor
Author
There was a problem hiding this comment.
yes, the naming is a bit confusing. Let me change that and update the comments. Having this logic here is easier to test than in connection pool.
Signed-off-by: Henry Yang <hyang@lyft.com>
mattklein123
approved these changes
Sep 30, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, much more clear!
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Henry Yang <hyang@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: When mirroring traffic from a non-hashtagging-enabled cluster to a cluster that supports OSS Redis Cluster protocol, we need to ensure hashtagging is enabled on the OSS Redis Cluster. Otherwise there will be a lot of redirection traffic.
Risk Level: Low
Testing: Added unit test
Docs Changes: N/A
Release Notes: Yes