clang-tidy: check casing on type aliases#8408
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Sep 27, 2019
Merged
clang-tidy: check casing on type aliases#8408mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
derekargueta
commented
Sep 27, 2019
| using HashSet = | ||
| absl::flat_hash_set<StatNameStorage, HeterogeneousStatNameHash, HeterogeneousStatNameEqual>; | ||
| using iterator = HashSet::iterator; | ||
| using Iterator = HashSet::iterator; |
Member
Author
There was a problem hiding this comment.
I was on the fence about exempting this since ::iterator is more STL-like, but prefer fewer exemptions since it doesn't have to be lower_case (unlike is_transparent and type) - open to opinions.
derekargueta
commented
Sep 27, 2019
| using iterator = DataContainer::iterator; | ||
| using const_iterator = DataContainer::const_iterator; | ||
| using Iterator = DataContainer::iterator; | ||
| using ConstIterator = DataContainer::const_iterator; |
Signed-off-by: Derek Argueta <dereka@pinterest.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Derek Argueta <dereka@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: verify
CamelCaseforusing FooBar = ...;statements with some exceptions.Risk Level: low
Testing: existing
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com