Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
reviewed
Sep 26, 2019
| bazel_options).decode().strip() | ||
|
|
||
| compdb = [] | ||
| for compdb_file in Path(execroot).glob("**/*.compile_commands.json"): |
Member
There was a problem hiding this comment.
Can you provide a high-level explanation (just in this thread, or maybe a comment) of how the compile_commands.json sourcing changed? Seems generally cleaner, just this glob is a tiny bit scary.
Member
Author
There was a problem hiding this comment.
This method implements what is done in https://github.com/grailbio/bazel-compilation-database/blob/master/generate.sh (which I made method level comment). This glob is from find here: https://github.com/grailbio/bazel-compilation-database/blob/master/generate.sh#L55
htuch
approved these changes
Sep 27, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Also moves to python3. Not moving clang-tidy to AZP yet to wait AZP stabilize a bit more. Risk Level: Low Testing: local, CI Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Also moves to python3. Not moving clang-tidy to AZP yet to wait AZP stabilize a bit more.
Risk Level: Low
Testing: local, CI
Docs Changes: N/A
Release Notes: N/A