config: add proxy version to bootstrap#8386
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
@mattklein123 @htuch PTAL |
mattklein123
left a comment
There was a problem hiding this comment.
Thanks @ramaraochavali at a high level this looks good but I have one API question for @htuch
| // Optional proxy version which will be used to set the value of :ref:`server.version statistic | ||
| // <server_statistics>` if specified. Envoy will not process this value, it will be sent as is to | ||
| // :ref:<stats sinks <envoy_api_msg_config.metrics.v2.StatsSink>. | ||
| google.protobuf.UInt64Value proxy_version = 19; |
There was a problem hiding this comment.
@htuch thoughts on whether this should go into the Node message?
There was a problem hiding this comment.
Yeah. The Node message will eventually have a semantic version, but not one specified (it will come from the API, not Envoy build). There will also be a user agent string, which probably will include a git SHA in the case of Envoy.
I view the version here to be purely a stats convenience and not useful for anything in xDS. I think if we rename this to stats_server_version_override then this sorts this problem out.
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo the naming comment thread, nice work!
| // Optional proxy version which will be used to set the value of :ref:`server.version statistic | ||
| // <server_statistics>` if specified. Envoy will not process this value, it will be sent as is to | ||
| // :ref:<stats sinks <envoy_api_msg_config.metrics.v2.StatsSink>. | ||
| google.protobuf.UInt64Value proxy_version = 19; |
There was a problem hiding this comment.
Yeah. The Node message will eventually have a semantic version, but not one specified (it will come from the API, not Envoy build). There will also be a user agent string, which probably will include a git SHA in the case of Envoy.
I view the version here to be purely a stats convenience and not useful for anything in xDS. I think if we rename this to stats_server_version_override then this sorts this problem out.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
@htuch @mattklein123 changed as suggested. PTAL |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
This PR adds a proxy version to bootstrap which will be used to set
server.versionmetric.Risk Level: Low, optional config
Testing: Added tests
Docs Changes: Updated
Release Notes: Updated
Fixes #8318