adaptive concurrency: Add configurable jitter to minRTT calculation windows#8377
Merged
mattklein123 merged 9 commits intoenvoyproxy:masterfrom Sep 27, 2019
Merged
adaptive concurrency: Add configurable jitter to minRTT calculation windows#8377mattklein123 merged 9 commits intoenvoyproxy:masterfrom
mattklein123 merged 9 commits intoenvoyproxy:masterfrom
Conversation
mattklein123
requested changes
Sep 26, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Generally looks good, thanks with some small nits and fixups needed. I will take another pass once fixed up. Thank you!
/wait
api/envoy/config/filter/http/adaptive_concurrency/v3alpha/adaptive_concurrency.proto
Outdated
Show resolved
Hide resolved
...e/extensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller.cc
Outdated
Show resolved
Hide resolved
...e/extensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller.cc
Outdated
Show resolved
Hide resolved
...ensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller_test.cc
Outdated
Show resolved
Hide resolved
added 2 commits
September 26, 2019 11:44
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
Signed-off-by: Tony Allen <tallen@lyft.com>
mattklein123
requested changes
Sep 26, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, looks great with 2 small nits.
/wait
...ensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller_test.cc
Outdated
Show resolved
Hide resolved
...e/extensions/filters/http/adaptive_concurrency/concurrency_controller/gradient_controller.cc
Outdated
Show resolved
Hide resolved
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…indows (envoyproxy#8377) Signed-off-by: Tony Allen <tallen@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jitterfield has been added to the minRTT calculation parameters. This jitter is percentage-based and adds a randomized time delta that will be introduced to the start of the minRTT calculation window. This prevents unwanted synchronization of the minRTT calculation windows.Risk: Very low, filter is not available for use yet.
Fixes #8337