Fix jwks_fetcher crash with missing jwks cluster for remote_jwks#8370
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Sep 26, 2019
Merged
Fix jwks_fetcher crash with missing jwks cluster for remote_jwks#8370lizan merged 1 commit intoenvoyproxy:masterfrom
lizan merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
|
🔨 rebuilding |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Description: If the cluster for remote_jwks is not configured. jwks_fetcher will throw exception, since there is not exception catch in the data flow, it will crash the envoy. Fix: check if cluster is configured, if not, failed the jwks fetch, and fail the request. not to crash envoy. Risk Level: Low Testing: added a new integration test Docs Changes: None Release Notes: None Fixes envoyproxy#8363 Signed-off-by: Wayne Zhang <qiwzhang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang qiwzhang@google.com
Description:
If the cluster for remote_jwks is not configured. jwks_fetcher will throw exception, since there is not exception catch in the data flow, it will crash the envoy.
Fix: check if cluster is configured, if not, failed the jwks fetch, and fail the request. not to crash envoy.
Risk Level: Low
Testing: added a new integration test
Docs Changes: None
Release Notes: None
[Optional Fixes #Issue] #8363
[Optional Deprecated:]