stats: create StatNameSet via SymbolTable::makeSet rather than construction.#8369
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Sep 26, 2019
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ing them. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
Note the CI failures are due to out-of-disk-space in azp. |
mattklein123
requested changes
Sep 26, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks looks great with a few small comments.
/wait
| // This must be held during both encode() and free(). | ||
| mutable Thread::MutexBasicLockable lock_; | ||
|
|
||
| // This must be held while updating stat_name_sets_. |
Member
There was a problem hiding this comment.
For simplicity thoughts on just using the lock you already have defined? Do we really need 2 locks?
|
|
||
| StatNameSet(SymbolTable& symbol_table, absl::string_view name); | ||
|
|
||
| std::string name_; |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…uction. (envoyproxy#8369) Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Split from #8116 -- refactor the StatNameSet construction so it must be done via a method on SymbolTable. This allows, in #8116, recent-lookup requests to be aggregated across the SymbolTable and all associated sets.
This also adds a name for the sets, though it's not used for anything yet.
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a