protoxform: remove deprecated fields in v3alpha.#8368
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 25, 2019
Merged
protoxform: remove deprecated fields in v3alpha.#8368htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
We should start tagging messages with "option deprecated = true;" if we want them to be auto-deprecated by protoxform going forward. Risk level: Low (v3alpha is not used yet) Testing: bazel test @envoy_api//..., manual diff inspection. Signed-off-by: Harvey Tuch <htuch@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
We should start tagging messages with "option deprecated = true;" if we want them to be auto-deprecated by protoxform going forward. Risk level: Low (v3alpha is not used yet) Testing: bazel test @envoy_api//..., manual diff inspection. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should start tagging messages with "option deprecated = true;" if we
want them to be auto-deprecated by protoxform going forward.
Risk level: Low (v3alpha is not used yet)
Testing: bazel test @envoy_api//..., manual diff inspection.
Signed-off-by: Harvey Tuch htuch@google.com