owners: updating codeowners file#8365
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
@snowp @alyssawilk @eziskind @htuch @mattklein123 @zuercher @gsagula @dio @jose @rshriram @qiwzhang @lizan @fengli79 @lavignes @yuval-k @klarose @PiotrSikora @wozz @taiki45 @trabetti @ramaraochavali If you're not comfortable doing reviews for the files specified here, please either comment here or take it up with me offline and I'll remove your handle and look into alternates. Also if anyone values the comment blocks I can add them in but I find the directory name generally sufficient. WDYT? |
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for putting this together.
CODEOWNERS
Outdated
| /*/extensions/filters/http/router @alyssawilk @mattklein123 @snowp | ||
| /*/extensions/filters/http/ext_authz @gsagula @dio | ||
| /*/extensions/filters/http/grpc_web @fengli79 @lizan | ||
| /*/extensions/filters/http/common/aws @lavignes @dio |
There was a problem hiding this comment.
I did cover this on line 51
There was a problem hiding this comment.
Just wanted to call it out especially since the two lines didn't match :)
There was a problem hiding this comment.
oh good catch, thanks! Must have been after we landed the fix format checks and we just forgot to take it out.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
3ff9160
Adding codeowners for unowned extension directories, mostly based on git blame, and sometimes based on maintainer suggestions. As a reminder, codeowners are the people we'll generally default to for reviews of files in a given directory. An Envoy maintainer still has to LGTM in order to merge, and generally that'd end up being the maintainer listed in codeowners. Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Adding codeowners for unowned extension directories, mostly based on git blame, and sometimes based on maintainer suggestions.
As a reminder, codeowners are the people we'll generally default to for reviews of files in a given directory. An Envoy maintainer still has to LGTM in order to merge, and generally that'd end up being the maintainer listed in codeowners.
Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a