debug: add envoy version stamp to backtrace#8358
Merged
lizan merged 4 commits intoenvoyproxy:masterfrom Sep 26, 2019
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
alyssawilk
previously approved these changes
Sep 25, 2019
| RELEASE_ASSERT(sigaltstack(&stack, &previous_altstack_) == 0, ""); | ||
|
|
||
| // Make sure VersionInfo::version() is initialized so we don't allocate std::string in signal | ||
| // handlers. |
| */ | ||
| void logTrace() { | ||
| ENVOY_LOG(critical, "Backtrace (use tools/stack_decode.py to get line numbers):"); | ||
| ENVOY_LOG(critical, "Envoy version: {}", VersionInfo::version()); |
Contributor
There was a problem hiding this comment.
What do you think of adding EXPECT_LOG_CONTAINS for "Envoy version" in backtrace_test just to make sure we don't lose this?
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
alyssawilk
approved these changes
Sep 25, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Description: Add envoy version stamp to backtrace logging so we don't have to ask the exact version of the backtrace. Risk Level: Low Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add envoy version stamp to backtrace logging so we don't have to ask the exact version of the backtrace.
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Lizan Zhou lizan@tetrate.io