api: generate v3alpha from v2 via protoxform.#8356
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 25, 2019
Merged
Conversation
This takes protoxform from being a v2 format tool to being able to generate something similar to what ./api/migration/v3alpha.sh generates. Risk level: Low (v3alpha not used yet) Testing: fix_format, manual verification that the delta from ./api/migration/v3alpha.sh makes sense (for now). Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
commented
Sep 24, 2019
| option java_outer_classname = "CircuitBreakerProto"; | ||
| option java_multiple_files = true; | ||
| option java_package = "io.envoyproxy.envoy.api.v3alpha.cluster"; | ||
| option csharp_namespace = "Envoy.Api.V2.ClusterNS"; |
Member
Author
There was a problem hiding this comment.
These don't need to be in v3alpha, they will go away after we re-org envoy.api.v3alpha.
mattklein123
approved these changes
Sep 25, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
This takes protoxform from being a v2 format tool to being able to generate something similar to what ./api/migration/v3alpha.sh generates. Risk level: Low (v3alpha not used yet) Testing: fix_format, manual verification that the delta from ./api/migration/v3alpha.sh makes sense (for now). Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes protoxform from being a v2 format tool to being able to
generate something similar to what ./api/migration/v3alpha.sh generates.
Risk level: Low (v3alpha not used yet)
Testing: fix_format, manual verification that the delta from
./api/migration/v3alpha.sh makes sense (for now).
Signed-off-by: Harvey Tuch htuch@google.com