Upgrade io_opencensus_cpp.#8340
Conversation
* Fixes ocagent exporter bug where trace and span IDs were encoded incorrectly. * Adds support for service_name. Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
|
CI says |
|
Yeah, looks like fix_format is broken on master - I'll see if I can sort that out ASAP Meanwhile if this is a bugfix, can you please add a unit test so we make sure we're regression-proof? |
|
ok #8345 will fix format issues, at which point you can do a master merge and it should resolve the format issues. Sorry for the noise! |
Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
|
Done merge master. Thanks for the format fix! The bug was in occ code, not envoy code. |
|
Sure, but if we're now passing clusterName correctly into opencensus, can't we check somewhere in tracer_test that it's now there? |
|
The same question came up in #7354. The clusterName doesn't end up in e.g. the generated SpanData. The only thing we could meaningfully test in the Envoy driver code is the one line that puts it in the options struct. I think we should merge this as-is. |
alyssawilk
left a comment
There was a problem hiding this comment.
I think we should revisit code if we can't meaningfully test it
I'll buy that's out of scope of this PR but I think it's worth thinking about for the next one.
Fixes ocagent exporter bug where trace and span IDs were encoded incorrectly. Adds support for service_name. Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
Fixes ocagent exporter bug where trace and span IDs were encoded
incorrectly.
Adds support for service_name.
Signed-off-by: Emil Mikulic g-easy@users.noreply.github.com