api: improve performance of protodoc and protoxform file copies.#8336
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 24, 2019
Merged
api: improve performance of protodoc and protoxform file copies.#8336htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Previously, we were doing lots of bazel queries, which is slow. This patch switches to a nested bazel query which provides > 10x speedup, providing a better developer experience. Risk level: Low Testing: Verified RST output against an unmodified tree. Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
approved these changes
Sep 24, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…oyproxy#8336) Previously, we were doing lots of bazel queries, which is slow. This patch switches to a nested bazel query which provides > 10x speedup, providing a better developer experience. Risk level: Low Testing: Verified RST output against an unmodified tree. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were doing lots of bazel queries, which is slow. This
patch switches to a nested bazel query which provides > 10x speedup,
providing a better developer experience.
Risk level: Low
Testing: Verified RST output against an unmodified tree.
Signed-off-by: Harvey Tuch htuch@google.com