http: turning on absolute url support by default#8329
Merged
alyssawilk merged 2 commits intoenvoyproxy:masterfrom Sep 23, 2019
Merged
http: turning on absolute url support by default#8329alyssawilk merged 2 commits intoenvoyproxy:masterfrom
alyssawilk merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
requested changes
Sep 23, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small nits, thanks for this.
/wait
docs/root/intro/version_history.rst
Outdated
| * http: added the ability to configure the behavior of the server response header, via the :ref:`server_header_transformation<envoy_api_field_config.filter.network.http_connection_manager.v2.HttpConnectionManager.server_header_transformation>` field. | ||
| * http: added the ability to :ref:`merge adjacent slashes<envoy_api_field_config.filter.network.http_connection_manager.v2.HttpConnectionManager.merge_slashes>` in the path. | ||
| * http: remove h2c upgrade headers for HTTP/1 as h2c upgrades are currently not supported. | ||
| * http: absolute URL support is not on by default. The prior behavior can be reinstated by setting :ref:`allow_absolute_url <envoy_api_field_core.Http1ProtocolOptions.allow_absolute_url>` to false. |
test/integration/integration_test.cc
Outdated
| envoy::api::v2::core::Http1ProtocolOptions options; | ||
| options.mutable_allow_absolute_url()->set_value(true); | ||
| hcm.mutable_http_protocol_options()->CopyFrom(options); | ||
| // options.mutable_allow_absolute_url()->set_value(false); |
Member
There was a problem hiding this comment.
remove commented out code?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
As discussed on envoyproxy#8078 absolute URLs are part of the HTTP/1 spec and the code has been used for some time now - turning it up by default. Risk Level: Medium (changes to L7 for many users) Testing: updated tests for new defaults Docs Changes: no Release Notes: yes Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
As discussed on envoyproxy#8078 absolute URLs are part of the HTTP/1 spec and the code has been used for some time now - turning it up by default. Risk Level: Medium (changes to L7 for many users) Testing: updated tests for new defaults Docs Changes: no Release Notes: yes Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
As discussed on envoyproxy#8078 absolute URLs are part of the HTTP/1 spec and the code has been used for some time now - turning it up by default. Risk Level: Medium (changes to L7 for many users) Testing: updated tests for new defaults Docs Changes: no Release Notes: yes Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #8078 absolute URLs are part of the HTTP/1 spec and the code has been used for some time now - turning it up by default.
Risk Level: Medium (changes to L7 for many users)
Testing: updated tests for new defaults
Docs Changes: no
Release Notes: yes