xds: make log levels consistent#8320
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
| } else { | ||
| auto& cluster_entry = warming_clusters_.at(cluster_name); | ||
| ENVOY_LOG(info, "add/update cluster {} starting warming", cluster_name); | ||
| ENVOY_LOG(debug, "add/update cluster {} starting warming", cluster_name); |
There was a problem hiding this comment.
In the above if block, these are logged at debug level, so making it consistent with that.
source/server/lds_api.cc
Outdated
| for (const auto& removed_listener : removed_resources) { | ||
| if (listener_manager_.removeListener(removed_listener)) { | ||
| ENVOY_LOG(info, "lds: remove listener '{}'", removed_listener); | ||
| ENVOY_LOG(debug, "lds: remove listener '{}'", removed_listener); |
There was a problem hiding this comment.
In cds, these are logged at debug level - so making it consistent with that.
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for this fix. It makes sense to me to make this consistent, though I'm not sure if these messages should be info or debug. I don't have a strong opinion. @lambdai any thought here?
|
Honestly I didn't pay enough attention to the log prior to this PR. WDYT? |
|
@lambdai Sure. I have no strong opinion on whether it should be |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
Ok. I changed the cds logs to be |
|
/lgtm |
|
/retest envoy-linux |
|
🤷♀️ nothing to rebuild. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8320 in repo envoyproxy/envoy |
|
@mattklein123 This is stuck with azure pipeline, can you PTAL if this makes sense? |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Log levels between cds and lds are inconsistent in the way resource additions are logged. cds logs them at debug and lds logs them at info. This PR makes it consistent. If it is intentionally done like that, I am happy to close this PR
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A