api: protoxform tool and API reformat.#8309
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Sep 23, 2019
Merged
Conversation
This patch introduces a new tool, protoxform, that will be the basis of the v2 -> v3 migration tooling. It operates as a Python protoc plugin, within the same framework as protodoc, and provides the ability to operate on protoc AST input and generate proto output. As a first step, the tool is applied reflexively on v2, and functions as a formatting tool. In later patches, this will be added to check_format/fix_format scripts and CI. Risk level: medium (it's possible that some inadvertent wire changes occur, if they do, this patch should be rolled back). Testing: manual inspection of diff, bazel test //test/..., some grep/diff scripts to ensure we haven't lost any comments. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
commented
Sep 20, 2019
| @@ -0,0 +1,405 @@ | |||
| # protoc plugin to map from FileDescriptorProtos to a canonicaly formatted | |||
Member
Author
There was a problem hiding this comment.
Everything in api/ is generated by protoxform. The actual tooling deltas are in tool/.
Contributor
|
/checkowners! |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
requested changes
Sep 23, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
This is very impressive. TBH I mostly just skimmed the automated changes and the script, and just called out thing that I saw. Nothing is a crisis so up to you whether you want to action here or in follow ups.
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
pushed a commit
that referenced
this pull request
Sep 24, 2019
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Sep 24, 2019
Via ./api/migration/v3alpha.sh. This picks up the changes since the last sync, in particular the major reformat in envoyproxy#8309. Risk level: Low (not used yet). Testing: bazel build @envoy_api//... Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
Sep 24, 2019
Via ./api/migration/v3alpha.sh. This picks up the changes since the last sync, in particular the major reformat in #8309. Risk level: Low (not used yet). Testing: bazel build @envoy_api//... Signed-off-by: Harvey Tuch <htuch@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
This patch introduces a new tool, protoxform, that will be the basis of the v2 -> v3 migration tooling. It operates as a Python protoc plugin, within the same framework as protodoc, and provides the ability to operate on protoc AST input and generate proto output. As a first step, the tool is applied reflexively on v2, and functions as a formatting tool. In later patches, this will be added to check_format/fix_format scripts and CI. Part of envoyproxy#8082. Risk level: medium (it's possible that some inadvertent wire changes occur, if they do, this patch should be rolled back). Testing: manual inspection of diff, bazel test //test/..., some grep/diff scripts to ensure we haven't lost any comments. Signed-off-by: Harvey Tuch <htuch@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
This patch introduces a new tool, protoxform, that will be the basis of the v2 -> v3 migration tooling. It operates as a Python protoc plugin, within the same framework as protodoc, and provides the ability to operate on protoc AST input and generate proto output. As a first step, the tool is applied reflexively on v2, and functions as a formatting tool. In later patches, this will be added to check_format/fix_format scripts and CI. Part of envoyproxy#8082. Risk level: medium (it's possible that some inadvertent wire changes occur, if they do, this patch should be rolled back). Testing: manual inspection of diff, bazel test //test/..., some grep/diff scripts to ensure we haven't lost any comments. Signed-off-by: Harvey Tuch <htuch@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
envoyproxy#8309 and envoyproxy#8100 collided Risk Level: Low (cleanup) Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Via ./api/migration/v3alpha.sh. This picks up the changes since the last sync, in particular the major reformat in envoyproxy#8309. Risk level: Low (not used yet). Testing: bazel build @envoy_api//... Signed-off-by: Harvey Tuch <htuch@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
This patch introduces a new tool, protoxform, that will be the basis of the v2 -> v3 migration tooling. It operates as a Python protoc plugin, within the same framework as protodoc, and provides the ability to operate on protoc AST input and generate proto output. As a first step, the tool is applied reflexively on v2, and functions as a formatting tool. In later patches, this will be added to check_format/fix_format scripts and CI. Part of envoyproxy#8082. Risk level: medium (it's possible that some inadvertent wire changes occur, if they do, this patch should be rolled back). Testing: manual inspection of diff, bazel test //test/..., some grep/diff scripts to ensure we haven't lost any comments. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a new tool, protoxform, that will be the basis of
the v2 -> v3 migration tooling. It operates as a Python protoc plugin,
within the same framework as protodoc, and provides the ability to
operate on protoc AST input and generate proto output.
As a first step, the tool is applied reflexively on v2, and functions as
a formatting tool. In later patches, this will be added to
check_format/fix_format scripts and CI.
Part of #8082.
Risk level: medium (it's possible that some inadvertent wire changes
occur, if they do, this patch should be rolled back).
Testing: manual inspection of diff, bazel test //test/..., some
grep/diff scripts to ensure we haven't lost any comments.
Signed-off-by: Harvey Tuch htuch@google.com