Skip to content

access log: add support downstream direct remote address#8278

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
lizan:als_direct_downstream
Sep 19, 2019
Merged

access log: add support downstream direct remote address#8278
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
lizan:als_direct_downstream

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Sep 18, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Add downstream direct remote address to access log formatter and gRPC access logger.

Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Added

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested review from dio and mattklein123 September 18, 2019 08:48
Copy link
Copy Markdown
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@zuercher
Copy link
Copy Markdown
Member

tagging @envoyproxy/api-shepherds

Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zuercher zuercher self-assigned this Sep 18, 2019
@lizan lizan added the api-review-required API review required by @envoyproxy/api-shepherds label Sep 18, 2019
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattklein123 mattklein123 merged commit 1f8c137 into envoyproxy:master Sep 19, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Sep 24, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review-required API review required by @envoyproxy/api-shepherds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants