test: remove CONSTRUCT_ON_FIRST_USE from ads_integration_test#8272
Merged
zuercher merged 3 commits intoenvoyproxy:masterfrom Sep 18, 2019
Merged
test: remove CONSTRUCT_ON_FIRST_USE from ads_integration_test#8272zuercher merged 3 commits intoenvoyproxy:masterfrom
zuercher merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
…nfig_broken Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
…roxy#8272) This string constant is not constant when ads_integration_test is parameterized on delta/SotW. Risk Level: none Testing: test-only change Doc Changes: n /a Release Notes: n/a Signed-off-by: Fred Douglas <fredlas@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…roxy#8272) This string constant is not constant when ads_integration_test is parameterized on delta/SotW. Risk Level: none Testing: test-only change Doc Changes: n /a Release Notes: n/a Signed-off-by: Fred Douglas <fredlas@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
…roxy#8272) This string constant is not constant when ads_integration_test is parameterized on delta/SotW. Risk Level: none Testing: test-only change Doc Changes: n /a Release Notes: n/a Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This string constant is not constant when ads_integration_test is parameterized on delta/SotW.
Risk Level: none
Testing: test-only change