Skip to content

server: expose ProcessContext via the Api interface#8258

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
eziskind:processcontext
Sep 20, 2019
Merged

server: expose ProcessContext via the Api interface#8258
htuch merged 2 commits intoenvoyproxy:masterfrom
eziskind:processcontext

Conversation

@eziskind
Copy link
Copy Markdown
Contributor

Description: expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext
Risk Level: low
Testing: unit tests

Signed-off-by: Elisha Ziskind eziskind@google.com

Signed-off-by: Elisha Ziskind <eziskind@google.com>
Signed-off-by: Elisha Ziskind <eziskind@google.com>
@zuercher
Copy link
Copy Markdown
Member

@dio can you have a look?

@eziskind
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #8258 (comment) was created by @eziskind.

see: more, trace.

@eziskind
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 8258 in repo envoyproxy/envoy

@htuch
Copy link
Copy Markdown
Member

htuch commented Sep 17, 2019

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@eziskind
Copy link
Copy Markdown
Contributor Author

@dio could you take a look at this when you get a chance?

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htuch htuch merged commit a743395 into envoyproxy:master Sep 20, 2019
@eziskind eziskind deleted the processcontext branch September 20, 2019 19:41
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Sep 24, 2019
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext

Risk Level: low
Testing: unit tests

Signed-off-by: Elisha Ziskind <eziskind@google.com>
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext

Risk Level: low
Testing: unit tests

Signed-off-by: Elisha Ziskind <eziskind@google.com>
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext

Risk Level: low
Testing: unit tests

Signed-off-by: Elisha Ziskind <eziskind@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants