dns: enable dns failure refresh rate configuration#8226
Merged
htuch merged 5 commits intoenvoyproxy:masterfrom Sep 27, 2019
Merged
dns: enable dns failure refresh rate configuration#8226htuch merged 5 commits intoenvoyproxy:masterfrom
htuch merged 5 commits intoenvoyproxy:masterfrom
Conversation
Member
|
@snowp do you mind taking a look? |
snowp
previously approved these changes
Sep 18, 2019
Contributor
snowp
left a comment
There was a problem hiding this comment.
LGTM
@envoyproxy/api-shepherds for API review
htuch
reviewed
Sep 19, 2019
mattklein123
previously requested changes
Sep 19, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Generally LGTM with some small comments.
/wait
67400e7 to
40ca4e2
Compare
Member
Author
|
The CI is failing for a very weird reason. That's the new field I introduced in this PR, and it thinks the field existed already? |
Member
|
You have a merge conflict. /wait |
Member
|
Actually I'm not sure what the issue is. Try merging master. |
htuch
suggested changes
Sep 23, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Thanks, looks good but a few cleanups requested.
40ca4e2 to
4f01756
Compare
4f01756 to
f7ab87b
Compare
Member
Author
|
@htuch I've addressed your comments in f7ab87b. |
htuch
suggested changes
Sep 24, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM, final few comments.
/wait
Member
Author
|
@htuch I've addressed your latest comments in adc0da2. |
81979d7 to
eb95685
Compare
Member
Author
|
unrelated flakes? |
Member
|
@venilnoronha No, you'll need to update stats_integration_test for the per cluster memory test when you add a new field to cluster. |
This adds a new `dns_failure_refresh_rate` configuration to the `Cluster` type to allow the configuration of the DNS refresh rate during failures (empty responses). Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
17327da to
76ba7b9
Compare
Signed-off-by: Venil Noronha <veniln@vmware.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
This adds a new dns_failure_refresh_rate configuration to the Cluster type to allow the configuration of the DNS refresh rate during failures (empty responses). Risk Level: Low Testing: Updated tests Docs Changes: Updated docs Release Notes: Added an entry describing the change Fixes envoyproxy#7367 Signed-off-by: Venil Noronha <veniln@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This adds a new
dns_failure_refresh_rateconfiguration to theClustertype to allow the configuration of the DNS refresh rate during failures (empty responses).Risk Level: Low
Testing: Updated tests
Docs Changes: Updated docs
Release Notes: Added an entry describing the change
Fixes #7367