Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
junr03
reviewed
Sep 12, 2019
Member
junr03
left a comment
There was a problem hiding this comment.
lgtm, let me know if you want to kick up to another reviewer, or just an approve from me.
Member
Author
|
cc @achasveachas This skips most of build_setup.ps1 / do_ci.ps1 but follows the mac pattern and much simpler, we can grow this script and combine them later. |
Member
Author
|
@junr03 somehow the review disappeared, can you re approve? |
dio
approved these changes
Sep 16, 2019
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Setting up a job for Windows, this currently only build API build tests.
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A