test: runfiles path fixups to support site specific (e.g. google) imp…#819
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Apr 24, 2017
Merged
test: runfiles path fixups to support site specific (e.g. google) imp…#819mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
…ort.
* Access source files via {{ test_srcdir }} everywhere.
* Define TEST_RUNDIR, use it to access source files in shell scripts, instead of futzing with
$TEST_SRCDIR/$TEST_WORKSPACE.
* Wrap sh_test/cc_tests with sh_test_wrapper.sh and provide the ability to override main for C++
tests. This allows site specific customizations to the environment, e.g. overriding TEST_RUNDIR.
* Allow TestEnvironment::exec to support Python execution via symlinks.
* Some documentation in STYLE.md to capture the conventions.
* Fix a port dependency in admin_test.
test/run_envoy_tests.sh
Outdated
| #!/bin/bash | ||
|
|
||
| set -e | ||
| set -x |
mattklein123
approved these changes
Apr 24, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: these translations were graciously written by @XAntonioLuna @sgenius and @gonzalolarralde and published in Lyft Engineering en Español Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: these translations were graciously written by @XAntonioLuna @sgenius and @gonzalolarralde and published in Lyft Engineering en Español Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
wbpcode
pushed a commit
that referenced
this pull request
Aug 26, 2025
…g filter (#40718) ### Description This PR fixes a bug introduced in PR #40228, where OAuth2 cookies were removed for requests matching the `pass_through_matcher` configuration. This broke setups with multiple OAuth2 filter instances using different `pass_through_matcher` configurations, because the first matching instance removed the OAuth2 cookies--even when a passthrough was intended--impacting subsequent filters that still needed those cookies. The changes in this PR realign the filter behavior with the documentation, which states that `pass_through_matcher` provides an interface for users to specify header matching criteria such that, when applicable, the OAuth flow is entirely skipped. When this occurs, only the `oauth_passthrough` metric is incremented; no cookies or request headers are modified, and no OAuth success is recorded. In summary, when the `pass_through_matcher` configuration matches, the filter should simply skip processing and leave the request untouched. --- **Commit Message:** oauth2: fix passthrough logic to avoid modifying request when skipping filter **Risk Level:** Low **Testing:** Unit test added and single page app test fixed by [envoyproxy/examples PR #819](envoyproxy/examples#819) **Docs Changes:** N/A **Release Notes:** Added **Platform Specific Features:** N/A --------- Signed-off-by: Gustavo Moyano <gustavo.g.moyano@gmail.com>
melginaldi
pushed a commit
to melginaldi/envoy
that referenced
this pull request
Aug 26, 2025
…g filter (envoyproxy#40718) ### Description This PR fixes a bug introduced in PR envoyproxy#40228, where OAuth2 cookies were removed for requests matching the `pass_through_matcher` configuration. This broke setups with multiple OAuth2 filter instances using different `pass_through_matcher` configurations, because the first matching instance removed the OAuth2 cookies--even when a passthrough was intended--impacting subsequent filters that still needed those cookies. The changes in this PR realign the filter behavior with the documentation, which states that `pass_through_matcher` provides an interface for users to specify header matching criteria such that, when applicable, the OAuth flow is entirely skipped. When this occurs, only the `oauth_passthrough` metric is incremented; no cookies or request headers are modified, and no OAuth success is recorded. In summary, when the `pass_through_matcher` configuration matches, the filter should simply skip processing and leave the request untouched. --- **Commit Message:** oauth2: fix passthrough logic to avoid modifying request when skipping filter **Risk Level:** Low **Testing:** Unit test added and single page app test fixed by [envoyproxy/examples PR envoyproxy#819](envoyproxy/examples#819) **Docs Changes:** N/A **Release Notes:** Added **Platform Specific Features:** N/A --------- Signed-off-by: Gustavo Moyano <gustavo.g.moyano@gmail.com> Signed-off-by: Melissa Ginaldi <mginaldi@google.com>
wtzhang23
pushed a commit
to wtzhang23/envoy
that referenced
this pull request
Aug 27, 2025
…g filter (envoyproxy#40718) ### Description This PR fixes a bug introduced in PR envoyproxy#40228, where OAuth2 cookies were removed for requests matching the `pass_through_matcher` configuration. This broke setups with multiple OAuth2 filter instances using different `pass_through_matcher` configurations, because the first matching instance removed the OAuth2 cookies--even when a passthrough was intended--impacting subsequent filters that still needed those cookies. The changes in this PR realign the filter behavior with the documentation, which states that `pass_through_matcher` provides an interface for users to specify header matching criteria such that, when applicable, the OAuth flow is entirely skipped. When this occurs, only the `oauth_passthrough` metric is incremented; no cookies or request headers are modified, and no OAuth success is recorded. In summary, when the `pass_through_matcher` configuration matches, the filter should simply skip processing and leave the request untouched. --- **Commit Message:** oauth2: fix passthrough logic to avoid modifying request when skipping filter **Risk Level:** Low **Testing:** Unit test added and single page app test fixed by [envoyproxy/examples PR envoyproxy#819](envoyproxy/examples#819) **Docs Changes:** N/A **Release Notes:** Added **Platform Specific Features:** N/A --------- Signed-off-by: Gustavo Moyano <gustavo.g.moyano@gmail.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This PR request and response translation for gcp-gemini models. **Related Issues/PRs (if applicable)** Issue: envoyproxy/ai-gateway#609 --------- Signed-off-by: Sukumar Gaonkar <sgaonkar4@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ort.
Access source files via {{ test_rundir }} everywhere.
Define TEST_RUNDIR, use it to access source files in shell scripts, instead of futzing with
$TEST_SRCDIR/$TEST_WORKSPACE.
Wrap sh_test/cc_tests with sh_test_wrapper.sh and provide the ability to override main for C++
tests. This allows site specific customizations to the environment, e.g. overriding TEST_RUNDIR.
Allow TestEnvironment::exec to support Python execution via symlinks.
Some documentation in STYLE.md to capture the conventions.
Fix a port dependency in admin_test.