rbac: add DNS SAN as principal#7881
Merged
lizan merged 2 commits intoenvoyproxy:masterfrom Aug 15, 2019
Merged
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Contributor
Author
|
@lizan @mattklein123 PTAL |
Contributor
Author
|
@lizan can you PTAL when you get chance? |
lizan
previously approved these changes
Aug 14, 2019
Member
|
Can you merge master? |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Contributor
Author
|
@lizan merged master. PTAL |
lizan
approved these changes
Aug 14, 2019
Member
|
@htuch turns out this PR needs your approval |
htuch
approved these changes
Aug 15, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
@envoyproxy/api-shepherds API LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adds support for DNS SAN as Principal in RBAC filter.
Risk Level: Low
Testing: Added automated tests
Docs Changes: Updated
Release Notes: Added
Fixes #7836