config: distinct CLI options for strict/permissive checking of static…#7857
Merged
htuch merged 11 commits intoenvoyproxy:masterfrom Aug 19, 2019
Merged
config: distinct CLI options for strict/permissive checking of static…#7857htuch merged 11 commits intoenvoyproxy:masterfrom
htuch merged 11 commits intoenvoyproxy:masterfrom
Conversation
…/dynamic config. As per envoyproxy#6651, this PR plumbs in CLI options to allow independent control over static/dynamic unknown field validation. The defaults are the same for static as today (strict) and for dynamic we are by default permissive. This permits easy rollout of new API minor versions, including those related to security fixes. Fixes a regression that occurred in envoyproxy#7200 where strict/permissive checking CLI options were inverted. Risk level: Low (strictly more permissive by default) Testing: additional unit and integration tests added, exercising both permissive/strict checking over various parts of the API (bootstrap, listeners, clusters, xDS, network filters, etc). Fixes envoyproxy#6651 Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
reviewed
Aug 7, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
requested changes
Aug 14, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this is super awesome. Some small comments but looks great and I think this will be incredibly useful.
/wait
This was referenced Aug 15, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
previously approved these changes
Aug 16, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, this is awesome. A couple of optional small items, TIOLI.
Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/dynamic config.
As per #6651, this PR plumbs in CLI options to allow independent control over static/dynamic unknown
field validation.
The defaults are the same for static as today (strict) and for dynamic we are by default permissive.
This permits easy rollout of new API minor versions, including those related to security fixes.
Fixes a regression that occurred in #7200 where strict/permissive checking CLI options were
inverted.
As per #6818, added stats/warning for any unknown fields encountered.
Risk level: Low (strictly more permissive by default)
Testing: additional unit and integration tests added, exercising both permissive/strict checking
over various parts of the API (bootstrap, listeners, clusters, xDS, network filters, etc).
Fixes #6651
Fixed #6818
Signed-off-by: Harvey Tuch htuch@google.com