OriginalDstCluster: Use ThreadAwareLoadBalancer#7820
Merged
mattklein123 merged 10 commits intoenvoyproxy:masterfrom Aug 8, 2019
Merged
OriginalDstCluster: Use ThreadAwareLoadBalancer#7820mattklein123 merged 10 commits intoenvoyproxy:masterfrom
mattklein123 merged 10 commits intoenvoyproxy:masterfrom
Conversation
Use ThreadAwareLoadBalancer in OriginalDstCluster to pass OriginalDstClusterSharedPtr to LoadBalancer. Fixes: envoyproxy#7500 Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
mattklein123
requested changes
Aug 5, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks. Can you check CI and merge master?
/wait
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Member
|
Please check CI. /wait |
ThreadAwareLoadBalancers are stateless and recreted each time the host set changes. Remove the internal state from the OriginalDstCluster::LoadBalancer and use a shared host map instead. Allow CLUSTER_PROVIDED to be configured as the LB type for ORIGINAL_DST cluster type. Map the ORIGINAL_DST_LB type to CLUSTER_PROVIDED so that providing the ThreadAwareLoadBalancer will not throw. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Less chatty debugging experience. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Contributor
Author
|
Using a shared host map now. Hoping for the CI to pass :-) |
mattklein123
requested changes
Aug 7, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, this is a great cleanup. One deprecation request, otherwise LGTM. Thank you @jrajahalme!
/wait
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
ORIGINAL_DST_LB loab balancing type specifier is no longer needed, as CLUSTER_PROVIDED can be used instead. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
mattklein123
reviewed
Aug 8, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with one question.
/wait-any
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ThreadAwareLoadBalancer in OriginalDstCluster to pass
OriginalDstClusterSharedPtr to LoadBalancer.
Risk Level: Low
Fixes: #7500
Signed-off-by: Jarno Rajahalme jarno@covalent.io