bazel: make coverage great again (#415).#781
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Apr 18, 2017
Merged
Conversation
* Get rid of custom Bazel build. Now that we have a single test binary, we can completely bypass "bazel coverage", instead doing an unsandboxed "build test" with --coverage added to --cxxopt/--linkopt. We then have the .gcda from the single run in bazel-out/ and can run gcovr on it. * Document how to do coverage runs locally (i.e. not in the CI Docker image).
Member
|
This is so much simpler and easier to understand. I feel like there was a bunch of complexity put into https://github.com/lyft/envoy/blob/master/ci/build_setup.sh and https://github.com/lyft/envoy/blob/master/ci/do_ci.sh to make coverage work. Is there anything in those files that can be cleaned up now? |
Member
Author
|
I don't think so - the remaining complexity is from gcovr, avoiding symlink loops and making sure everything is at the right place relative to the source, object files and gcovr's PWD. |
mattklein123
approved these changes
Apr 18, 2017
mattklein123
pushed a commit
that referenced
this pull request
Jun 9, 2022
…ion header (#781) The logic was broken because it assumed an additional call would be performed to the auth server, which isn't the case. Per the filter documentation, a request is only considered subsequently authenticated if there's valid cookie that was set after the access token was received from the auth server: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/oauth2_filter More info about how to validate an access token (which we don't do, per above): https://www.oauth.com/oauth2-servers/token-introspection-endpoint/ https://datatracker.ietf.org/doc/html/rfc7662 Also fix the fact that ee shouldn't be calling continueDecoding() after decoder_callbacks_->encodeHeaders(). Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: Matt Klein <mklein@lyft.com>
tyxia
referenced
this pull request
in tyxia/envoy
Jun 14, 2022
…ion header (#781) The logic was broken because it assumed an additional call would be performed to the auth server, which isn't the case. Per the filter documentation, a request is only considered subsequently authenticated if there's valid cookie that was set after the access token was received from the auth server: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/oauth2_filter More info about how to validate an access token (which we don't do, per above): https://www.oauth.com/oauth2-servers/token-introspection-endpoint/ https://datatracker.ietf.org/doc/html/rfc7662 Also fix the fact that ee shouldn't be calling continueDecoding() after decoder_callbacks_->encodeHeaders(). Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Tianyu Xia <tyxia@google.com>
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
…ion header (envoyproxy#781) The logic was broken because it assumed an additional call would be performed to the auth server, which isn't the case. Per the filter documentation, a request is only considered subsequently authenticated if there's valid cookie that was set after the access token was received from the auth server: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/oauth2_filter More info about how to validate an access token (which we don't do, per above): https://www.oauth.com/oauth2-servers/token-introspection-endpoint/ https://datatracker.ietf.org/doc/html/rfc7662 Also fix the fact that ee shouldn't be calling continueDecoding() after decoder_callbacks_->encodeHeaders(). Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This PR is to add TTFT(time to first token) and ITL(inter token latency) in dynamic metadata, so that downstream clients can access these data. issues #723 --------- Signed-off-by: ydu208 <YDU208@bloomberg.net> Co-authored-by: ydu208 <YDU208@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of custom Bazel build. Now that we have a single test binary,
we can completely bypass "bazel coverage", instead doing an
unsandboxed "build test" with --coverage added to --cxxopt/--linkopt.
We then have the .gcda from the single run in bazel-out/ and can run
gcovr on it.
Document how to do coverage runs locally (i.e. not in the CI Docker
image).