Merged
Conversation
Member
Author
htuch
approved these changes
Apr 17, 2017
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo the fact the bazel.debug test didn't catch this. But we can address that in another PR.
Member
|
Can you fix do_ci.sh to build the |
Member
Author
|
@htuch updated |
htuch
approved these changes
Apr 17, 2017
Member
Author
|
@htuch updated again |
htuch
approved these changes
Apr 17, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: this PR adds emission of some downstream_rq metrics to compliment the upstream_rq metrics already emitted. This will allow users to have a view of both network success (upstream_rq) and client perceived success (downstream_rq) Risk Level: low Testing: local Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: this PR adds emission of some downstream_rq metrics to compliment the upstream_rq metrics already emitted. This will allow users to have a view of both network success (upstream_rq) and client perceived success (downstream_rq) Risk Level: low Testing: local Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This fixes pr_style_check.yaml which has a remaining old portion from #766. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.