bazel: change cfg of rule to exec#7758
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Jul 30, 2019
Merged
Conversation
The host environment isn't what you want when using remote execution Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Member
Author
|
cc @lizan has this been a problem for you? |
Member
|
Hmm, I think this is semantically wrong, i.e. it should be |
lizan
suggested changes
Jul 30, 2019
lizan
approved these changes
Jul 30, 2019
Member
Author
|
Can you post the error? What version of Bazel are you using? You may need
to upgrade.
On Thu, Aug 8, 2019 at 01:09 Derek ***@***.***> wrote:
This seems to have broken local doc building for me.
It's possible I'm missing something but looking over the bazel
documentation I don't see exec as a possible input.
https://docs.bazel.build/versions/master/skylark/lib/attr.html#parameters-3
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7758?email_source=notifications&email_token=AACFJ3SHIXCLNQFIWVL6NZ3QDPIBXA5CNFSM4IHY3RL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD322LXA#issuecomment-519415260>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACFJ3XLQIDGUT4N3UNN3ETQDPIBXANCNFSM4IHY3RLQ>
.
--
--
Keith Smiley
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host environment isn't what you want when using remote execution, instead we should use the exec environment