Merged
Conversation
Member
Author
|
/cc @htuch |
In envoyproxy/nighthawk#101 we update coverage to the new methodology. For that to work we need to be able to consume `_lib_internal_only` targets which aren't visible today. This proposes a change so we can make that happen. The naming is fairly clear that these targets shouldn't be used otherwise. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
5104112 to
a091e8d
Compare
Member
Author
|
(force pushed to fix |
oschaaf
added a commit
to oschaaf/nighthawk
that referenced
this pull request
Jul 29, 2019
In anticipation of envoyproxy/envoy#7749 it makes sense to further upgrade the Envoy dep, which hereby is done. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In envoyproxy/nighthawk#101 we update coverage to the new methodology.
For that to work we need to be able to consume
_lib_internal_onlytargets which aren't visible externally today.This proposes a change so we can make that happen.
The naming is fairly clear that these targets shouldn't be used otherwise.
Description:
Risk Level: low
Testing: N/A
Docs Changes: None
Release Notes: None