Skip to content

stats: rename StatDataAllocator and friends, paying down some tech-debt.#7591

Merged
zuercher merged 7 commits intoenvoyproxy:masterfrom
jmarantz:heap-stat-rename
Jul 17, 2019
Merged

stats: rename StatDataAllocator and friends, paying down some tech-debt.#7591
zuercher merged 7 commits intoenvoyproxy:masterfrom
jmarantz:heap-stat-rename

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz commented Jul 16, 2019

Description: Rename *StatDataAllocator to Allocator and AllocatorImpl, fixing filenames as well. This cleans up the last bit of tech-debt left from #7109 .
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

jmarantz added 4 commits July 15, 2019 17:33
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz marked this pull request as ready for review July 16, 2019 02:13
@jmarantz
Copy link
Copy Markdown
Contributor Author

/azp run envoy-macos

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jmarantz
Copy link
Copy Markdown
Contributor Author

/azp run envoy-macos

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@zuercher zuercher self-assigned this Jul 16, 2019
@zuercher
Copy link
Copy Markdown
Member

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: Build Error (failed build)

🐱

Caused by: a #7591 (comment) was created by @zuercher.

see: more, trace.

@zuercher
Copy link
Copy Markdown
Member

I think you may have to push a commit to get it to rerun the tests.

jmarantz added 2 commits July 16, 2019 20:11
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuercher zuercher merged commit 4703759 into envoyproxy:master Jul 17, 2019
@jmarantz jmarantz deleted the heap-stat-rename branch July 17, 2019 18:34
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Jul 22, 2019
…bt. (envoyproxy#7591)

Rename *StatDataAllocator to Allocator and AllocatorImpl, fixing filenames as well. This cleans up the last bit of tech-debt left from envoyproxy#7109.

Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants