test: remove unused function in lua_integration_test.cc#7590
Merged
zuercher merged 4 commits intoenvoyproxy:masterfrom Jul 17, 2019
Merged
test: remove unused function in lua_integration_test.cc#7590zuercher merged 4 commits intoenvoyproxy:masterfrom
zuercher merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yan Xue <yxyan@google.com>
zuercher
reviewed
Jul 16, 2019
Member
zuercher
left a comment
There was a problem hiding this comment.
Thanks. I'm not super familiar with LUA so I had a question.
Signed-off-by: crazyxy <yxyan@google.com>
Member
|
/retest |
|
🔨 rebuilding |
Member
|
Looks good to me, but I think you'll need to merge master to fix the release build error. That said, CI is pretty wonky right now, so you might hold off until we've straightened out whatever billing issue we have with Circle CI. |
Signed-off-by: crazyxy <yxyan@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yan Xue yxyan@google.com
Description:
Risk Level: low
Testing: bazel test //test/...
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]