server: skip lifecycle notifications on early envoy shutdown#7585
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Jul 17, 2019
Merged
server: skip lifecycle notifications on early envoy shutdown#7585htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Member
htuch
suggested changes
Jul 16, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Actually, before merging, I'm wondering if we need some documentation changes or something to make clear that the server lifecycle notifications only begin after all workers are started?
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Contributor
Author
Added comments to the header file |
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Jul 22, 2019
…oxy#7585) Skip lifecycle notifications which take a completion callback when envoy shuts down early before starting worker threads. This is needed because these registrations are typically implemented using Slot::runOnAllThreads which will not work correctly if worker threads have not been started. Risk Level: low Testing: unit tests Signed-off-by: Elisha Ziskind <eziskind@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Skip lifecycle notifications which take a completion callback when envoy shuts down early before starting worker threads. This is needed because these registrations are typically implemented using Slot::runOnAllThreads which will not work correctly if worker threads have not been started.
Risk Level: low
Testing: unit tests
Signed-off-by: Elisha Ziskind eziskind@google.com