dns: switch from ares_gethostbyname to ares_getaddrinfo#7395
Merged
htuch merged 7 commits intoenvoyproxy:masterfrom Jun 27, 2019
Merged
dns: switch from ares_gethostbyname to ares_getaddrinfo#7395htuch merged 7 commits intoenvoyproxy:masterfrom
htuch merged 7 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: crazyxy <yxyan@google.com>
Signed-off-by: crazyxy <yxyan@google.com>
htuch
suggested changes
Jun 25, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo comments, thanks for helping to make review easier.
/wait
Signed-off-by: crazyxy <yxyan@google.com>
htuch
suggested changes
Jun 26, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM, just two more quick comments.
/wait
Signed-off-by: crazyxy <yxyan@google.com>
Signed-off-by: crazyxy <yxyan@google.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Signed-off-by: crazyxy <yxyan@google.com>
Signed-off-by: crazyxy <yxyan@google.com>
Member
Author
|
@htuch @mattklein123 Could you please take a look? Thanks! |
dnoe
added a commit
to dnoe/envoy
that referenced
this pull request
Jul 11, 2019
In envoyproxy#7395, the c-ARES dependency version number was increased to gain access to a new getaddrinfo API by importing a specific nonrelease SHA from c-ARES. This specific SHA did not include c-ares/c-ares@b949cc3 which contains important security relevant fixes for the getaddrinfo API. This PR bumps the c-ARES version number to include them. Signed-off-by: Dan Noé <dpn@google.com>
alyssawilk
pushed a commit
that referenced
this pull request
Jul 11, 2019
In #7395, the c-ARES dependency version number was increased to gain access to a new getaddrinfo API by importing a specific nonrelease SHA from c-ARES. This specific SHA did not include c-ares/c-ares@b949cc3 , made subsequently, which contains important security relevant fixes for the getaddrinfo API. This PR bumps the c-ARES version number to include them. Signed-off-by: Dan Noé dpn@google.com Description: Risk Level: Low - external dependency version update Testing: bazel test //test/... Signed-off-by: Dan Noé <dpn@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazyxy yxyan@google.com
Upgrade c-ares. Part of #6975
Description: Upgrade c-ares. Switch from ares_gethostbyname to ares_getaddrinfo
Risk Level: Med
Testing: Unit test
Docs Changes: N/A
Release Notes: