bazel: minor fixes for consuming projects#732
Merged
mattklein123 merged 2 commits intomasterfrom Apr 11, 2017
Merged
Conversation
Thanks to @htuch for debugging help.
Member
|
LGTM. Do the integration tests with JSON pass with this? |
Member
Author
|
No not yet, I'm still debugging. |
Member
Author
|
@htuch I have everything working for Lyft private. I just added a more obvious failure in environment file substitute if a file can't be opened. Easier to debug. |
Member
|
LGTM. |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 12, 2017
This allows us to catch in CI breakages such as those fixed in envoyproxy#732. Also, it allows us to validate our example and story for other projects that consume Envoy for custom linking of filters keeps working. This adds the requirement of bind mounting in docker run with -v <some path>:/build for bazel.debug and bazel.coverage builds.
mattklein123
pushed a commit
that referenced
this pull request
Apr 12, 2017
This allows us to catch in CI breakages such as those fixed in #732. Also, it allows us to validate our example and story for other projects that consume Envoy for custom linking of filters keeps working. This adds the requirement of bind mounting in docker run with -v <some path>:/build for bazel.debug and bazel.coverage builds.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** controller: unreconized BackendSecurityPolicyType type caused panic **Related Issues/PRs (if applicable)** Fixes: #732 Signed-off-by: bitliu <bitliu@tencent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @htuch for debugging help.