Use git grep as opposed to system grep#7245
Conversation
When running on a system where BSD grep is on the PATH the check fails because bsd-grep follows symlinks on `grep -r`. This causes the check to find all the transitive dependencies that are using git on the `bazel-envoy` symbolic link directory Signed-off-by: Martin Conte Mac Donell <martin@lyft.com>
mattklein123
left a comment
There was a problem hiding this comment.
Thanks a ton for looking into this. I'm still a little confused as to why this doesn't effect upstream users running on OSX, but I will try to not think about it too hard. :)
|
@mattklein123 just for your mental sanity: this -does- happen upstream on osx environments that don’t have gnu-grep first on the PATH. I repro’ed with a fresh clone |
|
@Reflejo I see. Is it something about the mobile dev environment that switches this? |
|
@mattklein123 No, bsd grep is just the default on vanilla macos environments (aka any macos that didn't I assume most devs compiling envoy have gnu utils though and the ones that don't are just passing |
Updating to include envoyproxy/envoy#7245. Signed-off-by: Michael Rebello <mrebello@lyft.com>
Updating to include envoyproxy/envoy#7245. Signed-off-by: Michael Rebello <mrebello@lyft.com>
Updating to include #7245. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Updating to include #7245. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
When running on a system where BSD grep is on the PATH the check fails because bsd-grep follows symlinks on
grep -r. This causes the check to find all the transitive dependencies that are using git on thebazel-envoysymbolic link directory.Note this is also a better option because we only care about greping the files that are included in the repo and nothing else
Risk Level: Low
Testing: Done locally, added a bzl file with
remote =strings and it correctly failed.