tools: add namespace_check_excluded_paths arg to formatter#7211
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jun 8, 2019
Merged
tools: add namespace_check_excluded_paths arg to formatter#7211mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Adds a `namespace_check_excluded_paths` argument to the `check_format.py` script which allows for specifying file paths to ignore from the namespace check. This is useful for running the formatter against a file or folder that doesn't require namespaces in order to avoid having to add `NOLINT(namespace)` to each file. Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 7, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 Signed-off-by: Michael Rebello <mrebello@lyft.com> update envoy sha Signed-off-by: Michael Rebello <mrebello@lyft.com> reformat after rebasing Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 10, 2019
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: envoyproxy/envoy#7210 envoyproxy/envoy#7211 #55 Signed-off-by: Michael Rebello <mrebello@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: #7210 #7211 envoyproxy/envoy-mobile#55 Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
`clang-format` can be used for auto-formatting Java files the same way it is for Objective-C and C++. 2 spaces were selected for spacing to maintain parity with upstream. Depends on: #7210 #7211 envoyproxy/envoy-mobile#55 Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
namespace_check_excluded_pathsargument to thecheck_format.pyscript which allows for specifying file paths to ignore from the namespace check.This is useful for running the formatter against a file or folder that doesn't require namespaces in order to avoid having to add
NOLINT(namespace)to each file.Signed-off-by: Michael Rebello mrebello@lyft.com
Risk Level: None
Testing: Tested locally