Skip to content

test: hot restart integration test under bazel.#706

Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
htuch:hotrestart-test
Apr 7, 2017
Merged

test: hot restart integration test under bazel.#706
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
htuch:hotrestart-test

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Apr 6, 2017

This completes the work of Bazelifying everything under test/run_envoy_tests.sh. To run the
equivalent tests, just do "bazel test //test/...".

This completes the work of Bazelifying everything under test/run_envoy_tests.sh. To run the
equivalent tests, just do "bazel test //test/...".
@@ -0,0 +1,63 @@
#!/bin/bash

set -e
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of copying this code (not sure what changed vs. the other file), can we potentially just call this script from the other place to avoid duplication/cruft?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but won't we remove the original script shortly?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still going to take a couple of weeks to fully remove cmake. There is still a bunch of stuff to sort out, people to ramp up, etc. If the effort is small to avoid the duplication it seems better to me. If it's complicated for some reason it's fine to just copy it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will refactor.

@mattklein123 mattklein123 merged commit ae3307a into envoyproxy:master Apr 7, 2017
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
jpsim pushed a commit that referenced this pull request Nov 28, 2022
This is only called by the implementation of the `Engine`, and can be `private`.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
This is only called by the implementation of the `Engine`, and can be `private`.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
**Commit Message**

This adds support for almost-OpenAI-compatible providers where the only
difference with OpenAI is that it has different " version prefix". For
example, Gemini API [1] uses "/v1beta/openai" version prefix. Another
example is that Cohere AI [2] uses "/compatibility/v1", and DeepInfra
[3] uses "/v1/openai".

[1] https://ai.google.dev/gemini-api/docs/openai
[2] https://docs.cohere.com/v2/docs/compatibility-api
[3] https://deepinfra.com/docs/inference

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake added a commit that referenced this pull request Mar 3, 2026
**Commit Message**

Previously, the controller didn't fallback to /v1 version for OpenAI
schema since #706 which starts utilizing schema.version field. The field
was previously non nil hence in many cases, it was set to empty, and
that caused the backward incompatibility. This fixes it by defaulting to
v1 when the field is set but empty string.

**Related Issues/PRs (if applicable)**

Follow up on #706

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants