Skip to content

rbac: migrate from v2alpha to v2#7044

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
yangminzhu:rbac-v2
May 23, 2019
Merged

rbac: migrate from v2alpha to v2#7044
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
yangminzhu:rbac-v2

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

@yangminzhu yangminzhu commented May 22, 2019

Signed-off-by: Yangmin Zhu ymzhu@google.com

Description:
Risk Level: Low
Testing: Existing unit test and integration test
Docs Changes: Updated version history
Release Notes: Updated version history
Fixes #7031

@yangminzhu
Copy link
Copy Markdown
Contributor Author

yangminzhu commented May 22, 2019

The PR is ready for review, the coverage failing seems not related to this PR:

[----------] 8 tests from IpVersions/EdsIntegrationTest
[ RUN      ] IpVersions/EdsIntegrationTest.Http2HcClusterRewarming/0
[symbolize_elf.inc : 421] RAW: lseek(0, 2115445064, SEEK_SET) failed: errno=29
[symbolize_elf.inc : 473] RAW: Reading 1024 bytes from offset 2115445064 returned -1 which is not a multiple of 64.
... ...
[symbolize_elf.inc : 473] RAW: Reading 1024 bytes from offset 2115445064 returned -1 which is not a multiple of 64.
[symbolize_elf.inc : 421] RAW: lseek(0, 2115445064, SEEK_SET) failed: errno=29
[symbolize_elf.inc : 473] RAW: Reading 1024 bytes from offset 2115445064 returned -1 which is not a multiple of 64.
external/bazel_tools/tools/test/test-setup.sh: line 310: 33884 Segmentation fault      (core dumped) "${TEST_PATH}" "$@" 2>&1
FAIL: //test/coverage:coverage_tests (see /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy/bazel-out/k8-dbg/testlogs/test/coverage/coverage_tests/test.log)
Target //test/coverage:coverage_tests up-to-date:
  bazel-bin/test/coverage/coverage_tests
INFO: Elapsed time: 6282.624s, Critical Path: 1358.79s
INFO: 2856 processes: 2856 local.
INFO: Build completed, 1 test FAILED, 3706 total actions
//test/coverage:coverage_tests                                           FAILED in 1155.1s

/cc @liminw @mattklein123

@yangminzhu yangminzhu marked this pull request as ready for review May 22, 2019 22:31
@yangminzhu
migrate from v2alpha to v2
638758e 
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
venilnoronha
venilnoronha reviewed May 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@venilnoronha venilnoronha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I'm wondering if there are any implications on the control plane?

mattklein123
mattklein123 approved these changes May 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I will wait to merge a bit in case anyone has any concerns. @venilnoronha this will cause a compile break in management servers but it is wire compatible.

@mattklein123 mattklein123 self-assigned this May 23, 2019
@mattklein123 mattklein123 merged commit e5b2e52 into envoyproxy:master May 23, 2019
@yangminzhu yangminzhu deleted the rbac-v2 branch May 23, 2019 18:38
mpuncel added a commit to mpuncel/envoy that referenced this pull request May 23, 2019
@mpuncel
Merge branch 'master' into mpuncel/hedging-impl
e1b4e9d 
* master:
  test: Add coverage for IsolatedStoreImpl::find* (envoyproxy#7043)
  server: add ProcessContext (envoyproxy#7018)
  config: Implement both versions of onConfigUpdate() everywhere (envoyproxy#6879)
  gzip: add test for various compression strategy and level (envoyproxy#7055)
  Fix typo in comment for rds.RouteConfiguration.validate_clusters (envoyproxy#7056)
  mysql_filter: add handling for partial messages (envoyproxy#6885)
  migrate from v2alpha to v2 (envoyproxy#7044)
  tests: fix tsan test flake (envoyproxy#7052)
  upstream: fix HostUtility::healthFlagsToString (envoyproxy#7051)
  tech debt: eliminate absl::make_unique (envoyproxy#7034)
  router: add a route name field in route.Route list (envoyproxy#6776)
  ext_authz: configurable HTTP status code for network errors. (envoyproxy#6669)
  stats: remove const-cast for symbol-table in edcs_filter_test.cc (envoyproxy#7045)
  build: bump libevent to 3b1864b. (envoyproxy#7012)
  stats: improve test-coverage for a few stats-related functions. (envoyproxy#7038)
  docs: fix csrf filter source origin note (envoyproxy#7041)
  Fix common typo: grcp -> grpc (envoyproxy#7040)
  snapshot (envoyproxy#7036)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

+1 more reviewer

@venilnoronha venilnoronha venilnoronha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattklein123 mattklein123

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question: Promote RBAC filter API from v2alpha to v2

3 participants

@yangminzhu @venilnoronha @mattklein123