quiche: implement QuicEpollClock#6745
Merged
alyssawilk merged 15 commits intoenvoyproxy:masterfrom Apr 30, 2019
Merged
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @wu-bin |
Signed-off-by: Dan Zhang <danzh@google.com>
wu-bin
reviewed
Apr 30, 2019
bazel/external/quiche.BUILD
Outdated
| deps = [":quic_platform"], | ||
| ) | ||
|
|
||
| envoy_cc_test_library( |
Contributor
There was a problem hiding this comment.
It should be a envoy_cc_library?
| envoy_cc_test( | ||
| name = "quic_platform_test", | ||
| srcs = ["quic_platform_test.cc"], | ||
| copts = ["-Wno-unused-parameter"], |
Contributor
There was a problem hiding this comment.
nit: Add a quiche_copt for it?
Contributor
Author
There was a problem hiding this comment.
This might be only place need copts in this BUILD file. If it turns out that we need it in more places, I would prefer to define quiche_copt in a centralize place instead of defining it repeatedly in each BUILD file.
|
|
||
| envoy_cc_test_library( | ||
| name = "quic_platform_epoll_clock_lib", | ||
| srcs = [ |
Contributor
There was a problem hiding this comment.
nit: Fold "srcs" and "hdrs" to single line?
|
|
||
| namespace quic { | ||
|
|
||
| bool quic_monotonic_epoll_clock = false; |
Contributor
There was a problem hiding this comment.
Seems like this variable is not used, remove it?
| #include "quiche/quic/platform/api/quic_clock.h" | ||
|
|
||
| namespace quic { | ||
| extern bool quic_monotonic_epoll_clock; |
| extern bool quic_monotonic_epoll_clock; | ||
|
|
||
| // Clock to efficiently retrieve an approximately accurate time from an | ||
| // net::EpollServer. |
Contributor
There was a problem hiding this comment.
nit: epoll_server::SimpleEpollServer
| EXPECT_EQ(1000005, (clock.Now() - QuicTime::Zero()).ToMicroseconds()); | ||
| } | ||
|
|
||
| TEST_F(QuicPlatformTest, MonotonicityWithRealEpollClock) { |
Contributor
There was a problem hiding this comment.
The internal version of this test uses a real EpollServer, is it possible to do the same here?
Contributor
Author
There was a problem hiding this comment.
yes, switched to SimpleEpollServer
Signed-off-by: Dan Zhang <danzh@google.com>
wu-bin
approved these changes
Apr 30, 2019
| envoy_cc_test( | ||
| name = "quic_platform_test", | ||
| srcs = ["quic_platform_test.cc"], | ||
| copts = ["-Wno-unused-parameter"], |
Contributor
Author
|
/assign @alyssawilk |
alyssawilk
approved these changes
Apr 30, 2019
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 1, 2019
* master: (35 commits) Revert "api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692)" (envoyproxy#6761) Add test for the SocketOptionFactory::buildLiteralOptions() method. (envoyproxy#6724) Add test of parsing weighted_cluster route configuration to improve test coverage. (envoyproxy#6711) test: reducing H2 test permutations, increasing coverage time (envoyproxy#6753) Support gRPC-JSON translate without the google.api.http option. (envoyproxy#6731) quiche: implement QuicEpollClock (envoyproxy#6745) http: rc details for main Envoy workflow (envoyproxy#6560) quiche: implement QuicSystemEventLoopImpl (envoyproxy#6723) http: tracking 100s from upstream in stats (envoyproxy#6746) coverage: run without deprecated option (envoyproxy#6752) quiche: Implement spdy_test_helpers_impl. (envoyproxy#6741) [test] convert listener test stubs to v2 API (envoyproxy#6735) api: Add total_issued_requests to Upstream Locality and Endpoint Stats. (envoyproxy#6692) quiche: Implement http2_reconstruct_object_impl.h. (envoyproxy#6717) build: patch protobuf for UBSAN issue. (envoyproxy#6721) router: scoped rds (2a): scoped routing configuration protos (envoyproxy#6675) tap: use move semantics for submitTrace (envoyproxy#6709) quiche: add epoll_server for testing (envoyproxy#6650) Increase timeout of the coverage test run to 3000 seconds as it is now bumping in the current 2000s limit causing coverage run to abort sometimes. (envoyproxy#6722) quiche: Update tarball to commit 43a1c0f10f2855c3cd142f500e8d19ac6d6f5a8c (envoyproxy#6718) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
Define QuicEpollImpl as alias of SimpleEpollServer. Use that to define QuicEpollClock which is the clock used in quiche e2e test. Risk Level: low, test only Testing: Added tests of QuicEpollServer in quic_platform_test.cc. Part of envoyproxy#2557 Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define QuicEpollImpl as alias of SimpleEpollServer. Use that to define QuicEpollClock which is the clock used in quiche e2e test.
Risk Level: low, test only
Testing: Added tests of QuicEpollServer in quic_platform_test.cc.
Part of #2557