Use Swiss table with heterogenous lookup for CaseUnorderedSet#6710
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 26, 2019
Merged
Use Swiss table with heterogenous lookup for CaseUnorderedSet#6710mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
And remove explicit string construction from gzip filter usage. Signed-off-by: Dan Noé <dpn@google.com>
Signed-off-by: Dan Noé <dpn@google.com>
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
Apr 26, 2019
…roxy#6710) And remove explicit string construction from gzip filter usage. Signed-off-by: Dan Noé <dpn@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: By adding some "tags" to the functors used in
CaseUnorderedSetand switching it to be anabsl::flat_hash_setwe can take advantage of heterogeneous lookup ( https://abseil.io/tips/144 ) which eliminatesstd::stringconstruction when performing a lookup with astring_viewargument (obviously, the key type stored must be a concretestd::stringand not astring_view). Also convert the gzip filter to eliminate the explicitstd::stringconstruction previously required.Risk Level: Low
Testing:
bazel test //test/...Docs Changes: N/A
Release Notes: N/A
Part of: Issue #6580
Signed-off-by: Dan Noé dpn@google.com