ssl: increment stat when there is a handshake/connection error#669
Merged
mattklein123 merged 2 commits intomasterfrom Apr 1, 2017
Merged
ssl: increment stat when there is a handshake/connection error#669mattklein123 merged 2 commits intomasterfrom
mattklein123 merged 2 commits intomasterfrom
Conversation
I think this was lost when we did the bufferevent removal. Fixes #637
Member
Author
|
@lyft/network-team |
RomanDzhabarov
approved these changes
Apr 1, 2017
vijayendrabvs
pushed a commit
to vijayendrabvs/envoy
that referenced
this pull request
Apr 4, 2017
…proxy#669) I think this was lost when we did the bufferevent removal. Fixes envoyproxy#637
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: previously Envoy Mobile was not guarded against a race that resulted in a double deletion of an Http::ConnectionManagerImpl::ActiveStream. This PR creates state that protects against that race. Risk Level: low, integration test reproe'd the stack trace, and then updated prod code fixed as expected. Testing: new integration test. Fixes #668 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: previously Envoy Mobile was not guarded against a race that resulted in a double deletion of an Http::ConnectionManagerImpl::ActiveStream. This PR creates state that protects against that race. Risk Level: low, integration test reproe'd the stack trace, and then updated prod code fixed as expected. Testing: new integration test. Fixes #668 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was lost when we did the bufferevent removal.
Fixes #637