orca: add qps to load reports.#6677
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Apr 26, 2019
Merged
Conversation
It's helpful to a client-side LB to know the total endpoint serving QPS when making LB decisions. This could also be used as a signal for Envoy's least loaded LB. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
htuch
commented
Apr 22, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with one optional comment.
/wait-any
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Apr 25, 2019
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
Apr 26, 2019
It's helpful to a client-side LB to know the total endpoint serving QPS when making LB decisions. This could also be used as a signal for Envoy's least loaded LB. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's helpful to a client-side LB to know the total endpoint serving QPS when making LB decisions.
This could also be used as a signal for Envoy's least loaded LB.
Signed-off-by: Harvey Tuch htuch@google.com