Skip to content

quiche: Improve build rules for (test only) library quic_port_utils.#6672

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
wu-bin:quic_platform_test_lib
Apr 23, 2019
Merged

quiche: Improve build rules for (test only) library quic_port_utils.#6672
htuch merged 1 commit intoenvoyproxy:masterfrom
wu-bin:quic_platform_test_lib

Conversation

@wu-bin
Copy link
Copy Markdown
Contributor

@wu-bin wu-bin commented Apr 22, 2019

Description:

Improve build rules for (test only) library quic_port_utils, by removing the intermediate library //extensions/quic_listeners/quiche/platform:quic_platform_port_utils_impl_lib.

Risk Level: none, build only
Testing:

bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all
bazel test --test_output=all --define quiche=enabled test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all

Docs Changes: none
Release Notes: none

@wu-bin
Copy link
Copy Markdown
Contributor Author

wu-bin commented Apr 22, 2019

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: release (failed build)

🐱

Caused by: a #6672 (comment) was created by @wu-bin.

see: more, trace.

@wu-bin wu-bin marked this pull request as ready for review April 22, 2019 14:42
@wu-bin
Copy link
Copy Markdown
Contributor Author

wu-bin commented Apr 22, 2019

/assign @danzh2010

@wu-bin
Copy link
Copy Markdown
Contributor Author

wu-bin commented Apr 22, 2019

/retest

@repokitteh-read-only
Copy link
Copy Markdown

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6672 (comment) was created by @wu-bin.

see: more, trace.

Copy link
Copy Markdown
Contributor

@danzh2010 danzh2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danzh2010
Copy link
Copy Markdown
Contributor

/assign @htuch

@wu-bin
Copy link
Copy Markdown
Contributor Author

wu-bin commented Apr 23, 2019

/assign @alyssawilk

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta

@htuch htuch merged commit 478e734 into envoyproxy:master Apr 23, 2019
@wu-bin wu-bin changed the title Improve build rules for (test only) library quic_port_utils. quiche: Improve build rules for (test only) library quic_port_utils. Apr 24, 2019
@wu-bin wu-bin deleted the quic_platform_test_lib branch April 24, 2019 03:16
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 24, 2019
* master:
  docs: add extension policy (envoyproxy#6678)
  ext_authz: added ability to detect partial request body data (envoyproxy#6583)
  version_history.rst: jwt_authn change missed 1.10.0 (envoyproxy#6684)
  docs: fix link in pull request template (envoyproxy#6679)
  Explicitly convert absl::string_view to std::string. (envoyproxy#6687)
  docs: improving watermark docs/comments (envoyproxy#6683)
  http filter: add CSRF filter (envoyproxy#6470)
  event: reintroduce dispatcher stats (envoyproxy#6659)
  security: postmortem for CVE-2019-990[01] (envoyproxy#6597)
  Improve build rules for (test only) library quic_port_utils. (envoyproxy#6672)
  spell check: skip unsupported extensions when called with a file (envoyproxy#6648)
  Changed TestHooks to ListenerHooks (envoyproxy#6642)
  proto: move extension-specific linking validation into extensions (envoyproxy#6657)
  stats: add/test heterogenous set of StatNameStorage objects. (envoyproxy#6504)
  docs: move xds protocol to rst (envoyproxy#6670)
  fix version history order (envoyproxy#6671)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants