Skip to content

docs: start the work of snapping docs to the repo/docker#6376

Merged
htuch merged 4 commits intomasterfrom
version_docker_image_docs
Mar 26, 2019
Merged

docs: start the work of snapping docs to the repo/docker#6376
htuch merged 4 commits intomasterfrom
version_docker_image_docs

Conversation

@mattklein123
Copy link
Copy Markdown
Member

Part of #6361

Part of #6361

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Copy Markdown
Member Author

@bndw @moderation PTAL and let me know what you think. I think the only thing remaining after this is to figure out how to deal with the Dockerfiles. I read a bit, and I think one can use env var substitution in those files in FROM clauses, so I think with a bit of doc work we can probably make it happen. We might need to move some of the MD sandbox instructions into sphinx though to make this happen.

@moderation any interest in looking at ^ since you have been working in that area recently?

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Copy Markdown
Member Author

cc @htuch I fixed one of your TODOs from a while ago.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR generates that feeling when all the technical debt in the world evaporates away.. well at least some of it.

@htuch htuch added the waiting label Mar 26, 2019
bndw
bndw previously approved these changes Mar 26, 2019
Copy link
Copy Markdown
Contributor

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Deep linking into the repo at the relevant commit should help a ton!

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Copy Markdown
Member Author

@htuch updated

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@htuch htuch merged commit 00400d2 into master Mar 26, 2019
@htuch htuch deleted the version_docker_image_docs branch March 26, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants