docs: move example configs to load_assignment#6356
Closed
derekargueta wants to merge 2 commits intoenvoyproxy:masterfrom
Closed
docs: move example configs to load_assignment#6356derekargueta wants to merge 2 commits intoenvoyproxy:masterfrom
derekargueta wants to merge 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Member
Author
Member
Author
|
hmm will take a look at the test failure tomorrow morning, wasn't sure where the tests were for the example configs |
Contributor
|
@derekargueta As I mentioned at #6346 (comment) the template YAML files need a bunch of changes to move from v1 to v2 and not just load_assignment. I'm happy to take a stab at fully re-mediating if you like. |
Member
|
Thanks! Please ping me when it is ready. |
Member
Author
|
@moderation ah didn't see that thread. Yeah happy to let you finish that out. |
htuch
pushed a commit
that referenced
this pull request
Mar 27, 2019
…cation for Any and hosts deprecation for load_assignment (#6368) Update examples for Struct deprecation for Any Risk Level: Low - generated configs only, no changes to code Testing: bazel build //configs:example_configs, bazel test //test/... Docs Changes: None required Release Notes: None required Fixes #6025 Replaces #6356 Related #6346 Signed-off-by: Michael Payne <michael@sooper.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move example CDS configs from
hoststoload_assignmentDescription:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com