test: move some BaseIntegrationTest methods to their correct home.#635
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Mar 27, 2017
Merged
test: move some BaseIntegrationTest methods to their correct home.#635mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
BaseIntegrationTest methods belong to integration.cc rather than specific _test. This is useful in envoyproxy#415, since individual _test.cc files become independent test targets and linked objects, there's no need to have http2_integration_test depend on integration_test for example. This patch is pure code movement.
| #include "common/upstream/upstream_impl.h" | ||
|
|
||
| #include "test/mocks/upstream/mocks.h" | ||
| #include "test/integration/utility.h" |
mattklein123
approved these changes
Mar 27, 2017
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Sep 9, 2020
tests: add more coverage
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: the android master artifact is running out of time to build. Extending the timeout to allow it to build. Ultimately we need to track this time down #634 Risk Level: low Testing: CI run Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: the android master artifact is running out of time to build. Extending the timeout to allow it to build. Ultimately we need to track this time down #634 Risk Level: low Testing: CI run Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This Commit adds required fields on BackendSecurityPolicy for GCP authentication **Related Issues/PRs (if applicable)** Related Issue: envoyproxy/ai-gateway#609 --------- Signed-off-by: Sukumar Gaonkar <sgaonkar4@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseIntegrationTest methods belong to integration.cc rather than specific _test.
This is useful in #415, since individual _test.cc files become independent test targets and linked objects, there's no need to have http2_integration_test depend on integration_test for example.
This patch is pure code movement.