config: Remove entries from initial resource versions map#6320
Merged
htuch merged 14 commits intoenvoyproxy:masterfrom Mar 25, 2019
Merged
config: Remove entries from initial resource versions map#6320htuch merged 14 commits intoenvoyproxy:masterfrom
htuch merged 14 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Contributor
Author
|
A test of what I fixed here wouldn't fit naturally into the SubscriptionTestHarness setup. Is it worth adding a unit test file specific to delta_subscription_impl.h? |
Contributor
|
Going to assign this to someone familiar with this code, but IMO it is worth adding a new unit test file specific to the impl. |
Contributor
|
@dmitri-d can you take a first pass? |
Contributor
|
lgtm |
dmitri-d
previously approved these changes
Mar 20, 2019
htuch
suggested changes
Mar 21, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM; should we have a test for this?
/wait
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Contributor
Author
|
Test added. |
Signed-off-by: Fred Douglas <fredlas@google.com>
htuch
suggested changes
Mar 22, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Thanks, LGTM modulo remaining minor test related comments.
/wait
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
htuch
suggested changes
Mar 25, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
Looks good, one question...
/wait
Signed-off-by: Fred Douglas <fredlas@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Remove entry from the "initial resource versions" map when the server informs us that the corresponding resource has gone away.
Risk Level: low
#4991